Returning a string from ANSI-C

[smartsarath2003]

Hai,
I want to return a srting buffer from a C function. I have trouble doing that now

My sample code:

-----------------------------------------
char myfunction(void)
{
int i=1;
char buff[25]="Hai";
i=i+1;
return *buff;
}

char str_value = myfunction(void);
--------------------------------------------------

I am getting "88" in str_value when I return buff[25] and "115" when I return *buff, but not "Hai" in both cases.

Can some one please help me:!:
Thanks

 

[gliss]

There are many problems here.
I think the Programming forum would be more appropriate for this thread and return more helpful responses:


When posting code, it's helpful to the reader to use the code tag:

char myfunction(void)
{
int i=1;
char buff[25]="Hai";
i=i+1;
return *buff;
}

char str_value = myfunction(void);

Next, you are trying to return a local value by reference. buff is local to myfunction(). You need to pass by value, not by reference.
Next, your indexing is off. C based indexing starts at 0 and goes to size -1.
buff[25] hasn't been allocated. Valid addresses are buff[0] to buff[24].
If you use buff[25] = "Hai" as assignment then only buff[0], buff[1], buff[2] have been defined. Anything else is just what is memory.

Here is an example using a global variable.

#include <stdio.h>
#include <string.h>
 
char myfunction(void);
char buff[3];
 
int main ( void /*int argc, char *argv[]*/ ){
 
        printf("Before myfunction()...\n");
        puts(buff);
        printf("After myfunction()...\n");
        myfunction();
        puts(buff);
        return 0;
}
 
char myfunction(void)
{
        int i = 1;
        strcpy(buff, "Hai");
        //buff = "Hai";
        i = i + 1;
        return buff[0];
}
 
//char str_value = myfunction(void);

Here is using pass by reference:

#include <stdio.h>
#include <string.h>
                                                                                
char * myfunction(char *);
char buff[3];
                                                                                
int main ( void /*int argc, char *argv[]*/ ){
                                                                                
    char buff[3];
    printf("myfunction()...\n");
    puts(myfunction(buff));
    return 0;
}
                                                                                
char * myfunction( char * buff_pass )
{
    int i = 1;
    strcpy(buff_pass, "Hai");
    //buff = "Hai";
    i = i + 1;
    return buff_pass;
}
                                                                                
//char str_value = myfunction(void);

 

[swgchlry]

retuen buff is ok