Questions on semaphore and wakeup

[promach]

For https://xillybus.com/downloads/doc/xillybus_host_programming_guide_linux.pdf#page=29 and https://gist.github.com/promach/3751054163042d255f818724934799ed#file-fifo-c-L198-L214 , do you guys have any comments on the following statements ?

"Since this usage prevents blocking, it’s possible to delete the while() loop in the implementation of fifo request write(), as it is never invoked. Further code reduction is possible by removing the relevant semaphore, as well as its initialization and destruction code."