If RA0 is pressed,LED blinks endlessly,while if RA1 is pressed,then LED is OFF...

Kaybee909 · Aug 6, 2013

I need some help with my code using PIC16F84A...Now,my expectation is when RA0 is pressed,then all LEDs start "running-blinking" endlessly,but when RA1 is pressed then LEDs will stop(LED OFF) making PortB LOW...But my problem is that,when RA0 is preesed,the LEDs start perfectly but upon pressing RA1 it will never stop...So how do I stop the LEDs from blinking when RA1 is pressed? See attachment for the code.

Moorio · Aug 6, 2013

Have you tried to just turn off port 1 with the RA_1 Bit? That is the only thing that I can see is that you are keeping that point high.
Also have you tried to move the if statement with the RA_1 bit into the loop that way you are actively sampling it? With that if statement just kick yourself out of the endless loop?

- - - Updated - - -

Have you tried to just turn off port 1 with the RA_1 Bit? That is the only thing that I can see is that you are keeping that point high.
Also have you tried to move the if statement with the RA_1 bit into the loop that way you are actively sampling it? With that if statement just kick yourself out of the endless loop?

paulfjujo · Aug 6, 2013

hello,

you have a misplaced parenthesis and suppress the do.. while.

Code:

void main() {
TRISB= 0x00;    //Configure PORTB as output
TRISA = 0xFF;  //Configure PORTA as input
PORTB = 0x00;  //LED OFF
while(1)
 [B]{[/B]  // Infinite loop
if(PORTA.F0==1)//If switch is pressed LED is ON endless
{
PORTB = 0x80;  //Setting PortB as high
Delay_ms(100); // Maintain PortB as high for 100ms
PORTB = 0x40;
Delay_ms(100);
PORTB = 0x20;
Delay_ms(100);
PORTB = 0x10;
Delay_ms(100);
PORTB = 0x08;
Delay_ms(100);
PORTB = 0x04;
Delay_ms(100);
PORTB = 0x02;
Delay_ms(100);
PORTB = 0x01;
Delay_ms(100);
PORTB = 0x02;
Delay_ms(100);
PORTB = 0x04;
Delay_ms(100);
PORTB = 0x08;
Delay_ms(100);
PORTB = 0x10;
Delay_ms(100);
PORTB = 0x20;
Delay_ms(100);
PORTB = 0x40;
[B]Delay_ms(100);[/B]
PORTB = 0x80;
}

 if (RA1_bit==1)   //LED loop to stop if RA1 is pressed
 {
  PORTB= 0x00;}
  } 
[B]}[/B] // while
}

what happen if RA0 keep pressed and press RA1 in same time
you can add interlock condition
if((PortA.F0==1)&& (PortA.F1==0))
{
moving led
}
if ((PortA.F1==1)&&(PortA.F0==0))
{
PortB=0;
}

Kaybee909 · Aug 6, 2013

paulfjujo said:

hello,

you have a misplaced parenthesis and suppress the do.. while.

Code:

void main() {
TRISB= 0x00;    //Configure PORTB as output
TRISA = 0xFF;  //Configure PORTA as input
PORTB = 0x00;  //LED OFF
while(1)
 [B]{[/B]  // Infinite loop
if(PORTA.F0==1)//If switch is pressed LED is ON endless
{
PORTB = 0x80;  //Setting PortB as high
Delay_ms(100); // Maintain PortB as high for 100ms
PORTB = 0x40;
Delay_ms(100);
PORTB = 0x20;
Delay_ms(100);
PORTB = 0x10;
Delay_ms(100);
PORTB = 0x08;
Delay_ms(100);
PORTB = 0x04;
Delay_ms(100);
PORTB = 0x02;
Delay_ms(100);
PORTB = 0x01;
Delay_ms(100);
PORTB = 0x02;
Delay_ms(100);
PORTB = 0x04;
Delay_ms(100);
PORTB = 0x08;
Delay_ms(100);
PORTB = 0x10;
Delay_ms(100);
PORTB = 0x20;
Delay_ms(100);
PORTB = 0x40;
[B]Delay_ms(100);[/B]
PORTB = 0x80;
}

 if (RA1_bit==1)   //LED loop to stop if RA1 is pressed
 {
  PORTB= 0x00;}
  } 
[B]}[/B] // while
}

what happen if RA0 keep pressed and press RA1 in same time
you can add interlock condition
if((PortA.F0==1)&& (PortA.F1==0))
{
moving led
}
if ((PortA.F1==1)&&(PortA.F0==0))
{
PortB=0;
}

Hello,it's not working fine yet,the LEDs only blink once(No endless Loop) and just stop there,but upon pressing RA1 it put OFF the LEDs.Oops!...but we are almost getting there,I belief.

paulfjujo · Aug 6, 2013

suppress this extra parenthesis
if (RA1_bit==1) //LED loop to stop if RA1 is pressed
{
PORTB= 0x00; // this one }
}

Kaybee909 · Aug 6, 2013

paulfjujo said:
suppress this extra parenthesis
if (RA1_bit==1) //LED loop to stop if RA1 is pressed
{
PORTB= 0x00; // this one }
}

Hi Paul,am still getting "Sucked" in here. Still ON forever,have tried the advices and many more! I guess it's a lil bug.

vinothksr08 · Aug 7, 2013

hello... just try while loop because of the IF condition like...

Code:

while(RA0==1 || RA0==1&&RA1==0); \\endless blinking
while(RA1==1&&RA0==0)

embpic · Aug 7, 2013

best way use single bit and toggle it when key is pressed!
your code will look like as follows.

Code:

void main() {
TRISB= 0x00;    //Configure PORTB as output
TRISA = 0xFF;  //Configure PORTA as input
PORTB = 0x00;  //LED OFF
while(1) {  // Infinite loop

if(PORTA.F0==1 && toggle==1)//If switch is pressed LED is ON endless
{
toggle =~toggle;
}

else if (RA1_bit==1 && toggle==0)//LED loop to stop if RA1 is pressed
{
toggle =~toggle;

}

use if ...else condition instead of if.....if

- - - Updated - - -

best way use single bit and toggle it when key is pressed!
your code will look like as follows.

Code:

void main() {
TRISB= 0x00;    //Configure PORTB as output
TRISA = 0xFF;  //Configure PORTA as input
PORTB = 0x00;  //LED OFF
while(1) {  // Infinite loop

if(PORTA.F0==1 && toggle==1)//If switch is pressed LED is ON endless
{
toggle =~toggle;
}

else if (RA1_bit==1 && toggle==0)//LED loop to stop if RA1 is pressed
{
toggle =~toggle;

}

use if ...else condition instead of if.....if

If RA0 is pressed,LED blinks endlessly,while if RA1 is pressed,then LED is OFF...

Kaybee909

Newbie level 4

Attachments

Moorio

Newbie level 2

paulfjujo

Advanced Member level 4

Kaybee909

Newbie level 4

paulfjujo

Advanced Member level 4

Kaybee909

Newbie level 4

vinothksr08

Member level 3

embpic

Advanced Member level 3

Similar threads

If RA0 is pressed,LED blinks endlessly,while if RA1 is pressed,then LED is OFF...

Newbie level 4

Attachments

Newbie level 2

Advanced Member level 4

Newbie level 4

Advanced Member level 4

Newbie level 4

Member level 3

Advanced Member level 3

Similar threads

Privacy & Transparency

Privacy & Transparency